Changeset 12572 in josm

Timestamp:

2017-08-06T15:24:54+02:00 (7 years ago)

Author:

Klumbumbus

Message:

• fix #15097 - warn if ferry route way is not properly connected
• don't warn about bridge and tunnel on ferry routes
• see #14807 - don't warn about unknown noref=yes
• fix #15035 - warn for objects at null island (except the weather buoy)

Location:

trunk/data/validator

Files:

• combinations.mapcss (modified) (1 diff)
• geometry.mapcss (modified) (1 diff)
• ignoretags.cfg (modified) (1 diff)

trunk/data/validator/combinations.mapcss

@@ -304 +304 @@
 
 /* {0} on suspicious object */
-*[tunnel  ][!highway][!railway][!waterway][public_transport != platform][man_made != pipeline],
-*[bridge  ][!highway][!railway][!waterway][!piste:type][public_transport != platform][man_made !~ /^(bridge|pipeline)$/][building != bridge],
+*[tunnel  ][!highway][!railway][!waterway][!piste:type][public_transport != platform][route!=ferry][man_made != pipeline],
+*[bridge  ][!highway][!railway][!waterway][!piste:type][public_transport != platform][route!=ferry][man_made !~ /^(bridge|pipeline)$/][building != bridge],
 *[psv     ][!highway][!railway][!waterway][amenity !~ /^parking.*/],
 *[width   ][!highway][!railway][!waterway][!aeroway][!cycleway][!footway][!barrier][!man_made][!entrance][natural!=stone],

trunk/data/validator/geometry.mapcss

@@ -323 +323 @@
   throwWarning: tr("node connects highway and building");
 }
+
+/* #15035, must not warn for node 3815077900*/
+node[man_made!=monitoring_station][at(0.0,0.0)] {
+  throwError: tr("Object at Position 0.00E 0.00N. There is nothing at this position except an already mapped weather buoy.");
+  fixDeleteObject: this;
+}
+
+/* #15097 */
+way[highway][area!=yes] > node,
+way[man_made=pier] > node {
+  set node_in_highway_pier;
+}
+way[route=ferry][tunnel=yes] > node,
+way[route=ferry][bridge=yes] > node {
+  set node_in_ferry_bridge_tunnel;
+}
+way[route=ferry]!:closed >[index= 1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
+way[route=ferry]!:closed >[index=-1] node!.node_in_highway_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
+  throwWarning: tr("Ferry route is not connected to the road network or branches.");
+}
+way[amenity=ferry_terminal] > node,
+way[man_made=pier] > node {
+  set node_in_terminal_pier;
+}
+way[route=ferry]!:closed >[index= 1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area,
+way[route=ferry]!:closed >[index=-1] node[amenity!=ferry_terminal][man_made!=pier]!.node_in_terminal_pier!.node_in_ferry_bridge_tunnel:in-downloaded-area { 
+  throwWarning: tr("Ferry route is not connected to a ferry terminal or branches.");
+}

trunk/data/validator/ignoretags.cfg

@@ -134 +134 @@
 ;
 K:type=is_in
+K:noref=yes
 K:bridge=swing
 K:residential=rural