Changeset 12557 in josm for trunk/test/unit/org/openstreetmap/josm/io/OverpassDownloadReaderTest.java

Timestamp:

2017-08-02T20:41:01+02:00 (7 years ago)

Author:

Don-vip

Message:

see #15102 - first batch of HTTP unit tests mocking, using WireMock 2.7.1

File:

• trunk/test/unit/org/openstreetmap/josm/io/OverpassDownloadReaderTest.java (modified) (6 diffs)

trunk/test/unit/org/openstreetmap/josm/io/OverpassDownloadReaderTest.java

@@ -2 +2 @@
 package org.openstreetmap.josm.io;
 
+import static com.github.tomakehurst.wiremock.client.WireMock.aResponse;
+import static com.github.tomakehurst.wiremock.client.WireMock.get;
+import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo;
+import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.options;
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
@@ -7 +11 @@
 import java.util.regex.Matcher;
 
+import org.junit.Before;
 import org.junit.Rule;
 import org.junit.Test;
+import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.data.Bounds;
-import org.openstreetmap.josm.gui.preferences.server.OverpassServerPreference;
 import org.openstreetmap.josm.io.OverpassDownloadReader.OverpassOutpoutFormat;
 import org.openstreetmap.josm.testutils.JOSMTestRules;
 import org.openstreetmap.josm.tools.OverpassTurboQueryWizard;
 import org.openstreetmap.josm.tools.Utils;
+
+import com.github.tomakehurst.wiremock.junit.WireMockRule;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -28 +35 @@
     @Rule
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().timeout(15000);
+    public JOSMTestRules test = new JOSMTestRules().preferences();
+
+    /**
+     * HTTP mock.
+     */
+    @Rule
+    public WireMockRule wireMockRule = new WireMockRule(options().dynamicPort().usingFilesUnderDirectory(TestUtils.getTestDataRoot()));
+
+    private static final String NOMINATIM_URL_PATH = "/search?format=xml&q=";
+
+    /**
+     * Setup test.
+     */
+    @Before
+    public void setUp() {
+        NameFinder.NOMINATIM_URL_PROP.put("http://localhost:" + wireMockRule.port() + NOMINATIM_URL_PATH);
+    }
 
     private String getExpandedQuery(String search) {
         final String query = OverpassTurboQueryWizard.getInstance().constructQuery(search);
-        final String request = new OverpassDownloadReader(new Bounds(1, 2, 3, 4), OverpassServerPreference.getOverpassServer(), query)
+        final String request = new OverpassDownloadReader(new Bounds(1, 2, 3, 4), null, query)
                 .getRequestForBbox(1, 2, 3, 4)
                 .substring("interpreter?data=".length());
@@ -55 +78 @@
     }
 
+    private void stubNominatim(String query) {
+        wireMockRule.stubFor(get(urlEqualTo(NOMINATIM_URL_PATH + query))
+                .willReturn(aResponse()
+                    .withStatus(200)
+                    .withHeader("Content-Type", "text/xml")
+                    .withBodyFile("nominatim/" + query + ".xml")));
+    }
+
     /**
      * Tests evaluating the extended query feature {@code geocodeArea}.
@@ -60 +91 @@
     @Test
     public void testGeocodeArea() {
+        stubNominatim("London");
         final String query = getExpandedQuery("amenity=drinking_water in London");
         assertEquals("" +
@@ -78 +110 @@
     @Test
     public void testGeocodeUnknownArea() {
+        stubNominatim("foo-bar-baz-does-not-exist");
         final String query = OverpassDownloadReader.expandExtendedQueries("{{geocodeArea:foo-bar-baz-does-not-exist}}");
         assertEquals("// Failed to evaluate {{geocodeArea:foo-bar-baz-does-not-exist}}\n", query);