Changeset 12046 in josm

Timestamp:

2017-05-03T14:07:20+02:00 (7 years ago)

Author:

michael2402

Message:

In conflict resolution dialog, only scroll tab contents and prevent vertical scroll bar from appearing on small screens just because the horizontal scroll bar makes the dialog content smaller.

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• conflict/pair/ConflictResolver.java (modified) (3 diffs)
• dialogs/ConflictResolutionDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/conflict/pair/ConflictResolver.java

@@ -12 +12 @@
 
 import javax.swing.ImageIcon;
+import javax.swing.JComponent;
 import javax.swing.JPanel;
+import javax.swing.JScrollPane;
 import javax.swing.JTabbedPane;
 
@@ -98 +100 @@
         propertiesMerger.setName("panel.propertiesmerger");
         propertiesMerger.getModel().addPropertyChangeListener(this);
-        tabbedPane.add(tr("Properties"), propertiesMerger);
+        addTab(tr("Properties"), propertiesMerger);
 
         tagMerger = new TagMerger();
         tagMerger.setName("panel.tagmerger");
         tagMerger.getModel().addPropertyChangeListener(this);
-        tabbedPane.add(tr("Tags"), tagMerger);
+        addTab(tr("Tags"), tagMerger);
 
         nodeListMerger = new NodeListMerger();
         nodeListMerger.setName("panel.nodelistmerger");
         nodeListMerger.getModel().addPropertyChangeListener(this);
-        tabbedPane.add(tr("Nodes"), nodeListMerger);
+        addTab(tr("Nodes"), nodeListMerger);
 
         relationMemberMerger = new RelationMemberMerger();
         relationMemberMerger.setName("panel.relationmembermerger");
         relationMemberMerger.getModel().addPropertyChangeListener(this);
-        tabbedPane.add(tr("Members"), relationMemberMerger);
+        addTab(tr("Members"), relationMemberMerger);
 
         setLayout(new BorderLayout());
@@ -122 +124 @@
         conflictResolvers.add(nodeListMerger);
         conflictResolvers.add(relationMemberMerger);
+    }
+
+    private void addTab(String title, JComponent tabContent) {
+        JScrollPane scrollPanel = new JScrollPane(tabContent);
+        tabbedPane.add(title, scrollPanel);
     }
 

trunk/src/org/openstreetmap/josm/gui/dialogs/ConflictResolutionDialog.java

@@ -102 +102 @@
         HelpUtil.setHelpContext(this.getRootPane(), ht("Dialog/Conflict"));
 
-        setContent(p);
+        setContent(p, false);
     }