Changeset 11945 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

Timestamp:

2017-04-17T14:47:28+02:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:SCII_SPOILED_CHILD_INTERFACE_IMPLEMENTOR - Style - Class implements interface by relying on unknowing superclass methods

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -76 +76 @@
 import org.openstreetmap.josm.data.preferences.StringProperty;
 import org.openstreetmap.josm.gui.ExtendedDialog;
+import org.openstreetmap.josm.gui.IExtendedDialog;
 import org.openstreetmap.josm.gui.datatransfer.ClipboardUtils;
 import org.openstreetmap.josm.gui.mappaint.MapPaintStyles;
@@ -241 +242 @@
     }
 
+    /**
+     * Returns a new {@code AddTagsDialog}.
+     * @return a new {@code AddTagsDialog}
+     */
     protected AddTagsDialog getAddTagsDialog() {
         return new AddTagsDialog();
@@ -267 +272 @@
     }
 
-    protected interface IEditTagDialog {
-        ExtendedDialog showDialog();
-
-        int getValue();
-
+    /**
+     * Extracted interface of {@link EditTagDialog}.
+     */
+    protected interface IEditTagDialog extends IExtendedDialog {
+        /**
+         * Edit tags of multiple selected objects according to selected ComboBox values
+         * If value == "", tag will be deleted
+         * Confirmations may be needed.
+         */
         void performTagEdit();
     }
@@ -483 +492 @@
         }
 
-        /**
-         * Edit tags of multiple selected objects according to selected ComboBox values
-         * If value == "", tag will be deleted
-         * Confirmations may be needed.
-         */
         @Override
         public void performTagEdit() {