Changeset 11737 in josm

Timestamp:

2017-03-16T23:08:53+01:00 (7 years ago)

Author:

Don-vip

Message:

fix #5262 - do not change selection after splitting a way in "draw nodes" map mode

File:

• trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java

@@ -214 +214 @@
                 final SplitWayResult result = doSplitWay(getLayerManager().getEditLayer(), selectedWay, wayToKeep, newWays, sel);
                 Main.main.undoRedo.add(result.getCommand());
-                getLayerManager().getEditDataSet().setSelected(result.getNewSelection());
+                if (!result.getNewSelection().isEmpty()) {
+                    getLayerManager().getEditDataSet().setSelected(result.getNewSelection());
+                }
             }
         }
@@ -293 +295 @@
                         selectedWay, list.getSelectedValue(), newWays, selection);
                 Main.main.undoRedo.add(result.getCommand());
-                Main.getLayerManager().getEditDataSet().setSelected(result.getNewSelection());
+                if (!result.getNewSelection().isEmpty()) {
+                    Main.getLayerManager().getEditDataSet().setSelected(result.getNewSelection());
+                }
             }
         }
@@ -539 +543 @@
                 Arrays.asList("outer", "inner", "forward", "backward", "north", "south", "east", "west"));
 
+        final boolean isMapModeDraw = Main.map != null && Main.map.mapMode == Main.map.mapModeDraw;
+
         // Change the original way
         final Way changedWay = new Way(way);
         changedWay.setNodes(wayToKeep.getNodes());
         commandList.add(layer != null ? new ChangeCommand(layer, way, changedWay) : new ChangeCommand(way.getDataSet(), way, changedWay));
-        if (!newSelection.contains(way)) {
+        if (!isMapModeDraw && !newSelection.contains(way)) {
             newSelection.add(way);
         }
@@ -549 +555 @@
         newWays.remove(wayToKeep);
 
-        newSelection.addAll(newWays);
+        if (!isMapModeDraw) {
+            newSelection.addAll(newWays);
+        }
         for (Way wayToAdd : newWays) {
             commandList.add(layer != null ? new AddCommand(layer, wayToAdd) : new AddCommand(way.getDataSet(), wayToAdd));