Changeset 11527 in josm

Timestamp:

2017-02-02T18:52:17+01:00 (7 years ago)

Author:

stoecker

Message:

drop imagery entries which have an id, but are no longer in default list

Location:

trunk/src/org/openstreetmap/josm/data

Files:

• Preferences.java (modified) (1 diff)
• imagery/ImageryInfo.java (modified) (3 diffs)
• imagery/ImageryLayerInfo.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/Preferences.java

@@ -107 +107 @@
 
     private static final String[] OBSOLETE_PREF_KEYS = {
-      "hdop.factor" /* remove entry after April 2017 */
+      "hdop.factor", /* remove entry after April 2017 */
+      "imagery.layers.addedIds" /* remove entry after June 2017 */
     };
 

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -1033 +1033 @@
      */
     public void setNoTileHeaders(MultiMap<String, String> noTileHeaders) {
-       if (noTileHeaders == null) {
+       if (noTileHeaders == null || noTileHeaders.isEmpty()) {
            this.noTileHeaders = null;
        } else {
@@ -1053 +1053 @@
      */
     public void setNoTileChecksums(MultiMap<String, String> noTileChecksums) {
-        if (noTileChecksums == null) {
+        if (noTileChecksums == null || noTileChecksums.isEmpty()) {
             this.noTileChecksums = null;
         } else {
@@ -1073 +1073 @@
      */
     public void setMetadataHeaders(Map<String, String> metadataHeaders) {
-        this.metadataHeaders = metadataHeaders;
+        if (metadataHeaders == null || metadataHeaders.isEmpty()) {
+            this.metadataHeaders = null;
+        } else {
+            this.metadataHeaders = metadataHeaders;
+        }
     }
 

trunk/src/org/openstreetmap/josm/data/imagery/ImageryLayerInfo.java

@@ -170 +170 @@
             updateEntriesFromDefaults();
             buildIdMap(layers, layerIds);
+            dropOldEntries();
         }
     }
@@ -232 +233 @@
         Main.pref.putCollection("imagery.layers.default", newKnownDefaults);
 
-        // Add ids to user entries without id.
-        // Only do this the first time for each id, so the user can have
-        // custom entries that don't get updated automatically
-        Collection<String> addedIds = Main.pref.getCollection("imagery.layers.addedIds");
-        Collection<String> newAddedIds = new TreeSet<>(addedIds);
-        for (ImageryInfo info : layers) {
-            for (ImageryInfo def : defaultLayers) {
-                if (isSimilar(def, info) && def.getId() != null && !addedIds.contains(def.getId())) {
-                    if (!defaultLayerIds.containsKey(def.getId())) {
-                        // ignore ids used more than once (have been purged from the map)
-                        continue;
-                    }
-                    newAddedIds.add(def.getId());
-                    if (info.getId() == null) {
-                        info.setId(def.getId());
-                        changed = true;
-                    }
-                }
-            }
-        }
-        Main.pref.putCollection("imagery.layers.addedIds", newAddedIds);
-
         // automatically update user entries with same id as a default entry
         for (int i = 0; i < layers.size(); i++) {
@@ -263 +242 @@
             if (matchingDefault != null && !matchingDefault.equalsPref(info)) {
                 layers.set(i, matchingDefault);
+                Main.info(tr("Update imagery ''{0}''", info.getName()));
                 changed = true;
             }
@@ -268 +248 @@
 
         if (changed) {
+            save();
+        }
+    }
+
+    /**
+     * Drop entries with Id which do no longer exist (removed from defaults).
+     */
+    public void dropOldEntries() {
+        List<String> drop = new ArrayList<>();
+
+        for (Map.Entry<String, ImageryInfo> info : layerIds.entrySet()) {
+            if (!defaultLayerIds.containsKey(info.getKey())) {
+                remove(info.getValue());
+                drop.add(info.getKey());
+                Main.info(tr("Drop old imagery ''{0}''", info.getValue().getName()));
+            }
+        }
+
+        if (!drop.isEmpty()) {
+            for (String id : drop) {
+                layerIds.remove(id);
+            }
             save();
         }