Changeset 11452 in josm for trunk/src/org/openstreetmap/josm/gui/dialogs/layer/LayerListTransferHandler.java

Timestamp:

2017-01-12T01:24:40+01:00 (7 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib:SEO_SUBOPTIMAL_EXPRESSION_ORDER - Performance - Method orders expressions in a conditional in a sub optimal way

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/layer/LayerListTransferHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/layer/LayerListTransferHandler.java

@@ -96 +96 @@
             boolean isSameLayerManager = tableModel.getLayerManager() == layers.getManager();
 
-            if (support.getDropAction() == MOVE && isSameLayerManager) {
+            if (isSameLayerManager && support.getDropAction() == MOVE) {
                 for (Layer layer : layers.getLayers()) {
                     boolean wasBeforeInsert = layers.getManager().getLayers().indexOf(layer) <= dropLocation;