Context Navigation

Changeset 10254 in josm

Timestamp:

2016-05-20T22:21:01+02:00 (8 years ago)

Author:

Don-vip

Message:

sonar - squid:S1948 - Fields in a "Serializable" class should either be transient or serializable

Location:

trunk/src/org/openstreetmap/josm

Files:

-              r10174
+              r10254
     static class SegmentToKeepSelectionDialog extends ExtendedDialog {
         static final AtomicInteger DISPLAY_COUNT = new AtomicInteger();
         final Way selectedWay;
         final List<Way> newWays;
+        final transient Way selectedWay;
+        final transient List<Way> newWays;
         final JList<Way> list;
         final List<OsmPrimitive> selection;
         final Way wayToKeep;
+        final transient List<OsmPrimitive> selection;
+        final transient Way wayToKeep;
         SegmentToKeepSelectionDialog(Way selectedWay, List<Way> newWays, Way wayToKeep, List<OsmPrimitive> selection) {

-              r10181
+              r10254
     static final class PropertiesMembershipDialog extends ExtendedDialog {
         final ExistingBothNewChoice tags;
         final ExistingBothNewChoice memberships;
+        final transient ExistingBothNewChoice tags;
+        final transient ExistingBothNewChoice memberships;
         private PropertiesMembershipDialog(boolean preselectNew, boolean queryTags, boolean queryMemberships) {

-              r10216
+              r10254
     private class ComputeStyleListWorker extends RecursiveTask<List<StyleRecord>> implements Visitor {
         private final List<? extends OsmPrimitive> input;
         private final List<StyleRecord> output;
         private final ElemStyles styles = MapPaintStyles.getStyles();
+        private final transient List<? extends OsmPrimitive> input;
+        private final transient List<StyleRecord> output;
+        private final transient ElemStyles styles = MapPaintStyles.getStyles();
         private final int directExecutionTaskSize;

r10173	r10254
50	50	public class SplashScreen extends JFrame implements ChangeListener {
51	51
52		private final SplashProgressMonitor progressMonitor;
	52	private final transient SplashProgressMonitor progressMonitor;
53	53	private final SplashScreenProgressRenderer progressRenderer;
54	54

-              r10001
+              r10254
 public class DialogsPanel extends JPanel implements Destroyable {
     protected List<ToggleDialog> allDialogs = new ArrayList<>();
     protected MultiSplitPane mSpltPane = new MultiSplitPane();
     protected static final int DIVIDER_SIZE = 5;
+    private final List<ToggleDialog> allDialogs = new ArrayList<>();
+    private final MultiSplitPane mSpltPane = new MultiSplitPane();
+    private static final int DIVIDER_SIZE = 5;
     /**
 …
             throw new IllegalStateException();
         initialized = true;
         allDialogs = new ArrayList<>();
+        allDialogs.clear();
         for (ToggleDialog dialog: pAllDialogs) {

r10228	r10254
1230	1230	class TaginfoAction extends JosmAction {
1231	1231
1232		final StringProperty TAGINFO_URL_PROP = new StringProperty("taginfo.url", "https://taginfo.openstreetmap.org/");
	1232	final transient StringProperty TAGINFO_URL_PROP = new StringProperty("taginfo.url", "https://taginfo.openstreetmap.org/");
1233	1233
1234	1234	TaginfoAction() {

r10250	r10254
1000	1000
1001	1001	class IgnoreTagAction extends AbstractAction {
1002		final Tag tag;
	1002	final transient Tag tag;
1003	1003
1004	1004	IgnoreTagAction(String name, Tag tag) {

-              r10210
+              r10254
         private final JosmTextArea lblLat = newTextArea();
         private final JosmTextArea lblLon = newTextArea();
         private final Updater updater;
+        private final transient Updater updater;
         private final Color modifiedColor;
 …
     private static class MapViewer extends JMapViewer implements ChangeListener {
         private final Updater updater;
+        private final transient Updater updater;
         MapViewer(HistoryBrowserModel model) {
 …
         private final JosmTextArea lblDistance = newTextArea();
         private final Updater updater;
+        private final transient Updater updater;
         DistanceViewer(HistoryBrowserModel model) {

-              r10183
+              r10254
  * This wizard walks the user to the necessary steps to retrieve an OAuth Access Token which
  * allows JOSM to access the OSM API on the users behalf.
+ *
+ * @since 2746
  */
 public class OAuthAuthorizationWizard extends JDialog {
 …
     private ManualAuthorizationUI pnlManualAuthorisationUI;
     private JScrollPane spAuthorisationProcedureUI;
     private final Executor executor;
+    private final transient Executor executor;
     /**

-              r10132
+              r10254
     private int maxTextLength = -1;
     private boolean useFixedLocale;
+    private final transient InputContext privateInputContext = InputContext.getInstance();
     /**
 …
+    }
-    private final InputContext privateInputContext = InputContext.getInstance();
     @Override
     public InputContext getInputContext() {

r9991	r10254
96	96	* The types as preparsed collection.
97	97	*/
98		public Set<TaggingPresetType> types;
	98	public transient Set<TaggingPresetType> types;
99	99	public final transient List<TaggingPresetItem> data = new LinkedList<>();
100	100	public transient Roles roles;

r9799	r10254
81	81
82	82	static class HashSetWithLast<E> extends LinkedHashSet<E> {
83		protected E last;
	83	protected transient E last;
84	84
85	85	@Override

Note: See TracChangeset for help on using the changeset viewer.