Changeset 10106 in josm

Timestamp:

2016-04-03T16:22:18+02:00 (8 years ago)

Author:

Don-vip

Message:

fix coverity 1353523 + 1347995

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• dialogs/properties/PropertiesDialog.java (modified) (1 diff)
• history/HistoryLoadTask.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -230 +230 @@
 
     private final transient TaggingPresetHandler presetHandler = new TaggingPresetHandler() {
-        @Override public void updateTags(List<Tag> tags) {
+        @Override
+        public void updateTags(List<Tag> tags) {
             Command command = TaggingPreset.createCommand(getSelection(), tags);
-            if (command != null) Main.main.undoRedo.add(command);
-        }
-
-        @Override public Collection<OsmPrimitive> getSelection() {
-            if (Main.main == null) return null;
-            return Main.main.getInProgressSelection();
+            if (command != null) {
+                Main.main.undoRedo.add(command);
+            }
+        }
+
+        @Override
+        public Collection<OsmPrimitive> getSelection() {
+            return Main.main == null ? Collections.<OsmPrimitive>emptyList() : Main.main.getInProgressSelection();
         }
     };

trunk/src/org/openstreetmap/josm/gui/history/HistoryLoadTask.java

@@ -193 +193 @@
     protected static HistoryDataSet loadHistory(OsmServerHistoryReader reader, ProgressMonitor progressMonitor) throws OsmTransferException {
         HistoryDataSet ds = reader.parseHistory(progressMonitor.createSubTaskMonitor(1, false));
-        // load corresponding changesets (mostly for changeset comment)
-        OsmServerChangesetReader changesetReader = new OsmServerChangesetReader();
-        List<Long> changesetIds = new ArrayList<>(ds.getChangesetIds());
-
-        // query changesets 100 by 100 (OSM API limit)
-        int n = ChangesetQuery.MAX_CHANGESETS_NUMBER;
-        for (int i = 0; i < changesetIds.size(); i += n) {
-            for (Changeset c : changesetReader.queryChangesets(
-                    new ChangesetQuery().forChangesetIds(changesetIds.subList(i, Math.min(i + n, changesetIds.size()))),
-                    progressMonitor.createSubTaskMonitor(1, false))) {
-                ds.putChangeset(c);
+        if (ds != null) {
+            // load corresponding changesets (mostly for changeset comment)
+            OsmServerChangesetReader changesetReader = new OsmServerChangesetReader();
+            List<Long> changesetIds = new ArrayList<>(ds.getChangesetIds());
+
+            // query changesets 100 by 100 (OSM API limit)
+            int n = ChangesetQuery.MAX_CHANGESETS_NUMBER;
+            for (int i = 0; i < changesetIds.size(); i += n) {
+                for (Changeset c : changesetReader.queryChangesets(
+                        new ChangesetQuery().forChangesetIds(changesetIds.subList(i, Math.min(i + n, changesetIds.size()))),
+                        progressMonitor.createSubTaskMonitor(1, false))) {
+                    ds.putChangeset(c);
+                }
             }
         }
-
         return ds;
     }