source: josm/trunk/src/org/openstreetmap/josm/actions/MergeSelectionAction.java @ 5241

Revision 5233, 3.6 KB checked in by Don-vip, 9 days ago (diff)

fix #7684 - Various improvements in "upload=false" layers handling

  • Property svn:eol-style set to native
Line 
1// License: GPL. For details, see LICENSE file.
2package org.openstreetmap.josm.actions;
3
4import static org.openstreetmap.josm.gui.help.HelpUtil.ht;
5import static org.openstreetmap.josm.tools.I18n.tr;
6
7import java.awt.event.ActionEvent;
8import java.awt.event.KeyEvent;
9import java.util.Collection;
10import java.util.List;
11
12import org.openstreetmap.josm.data.osm.DataSet;
13import org.openstreetmap.josm.data.osm.OsmPrimitive;
14import org.openstreetmap.josm.data.osm.visitor.MergeSourceBuildingVisitor;
15import org.openstreetmap.josm.gui.dialogs.LayerListDialog;
16import org.openstreetmap.josm.gui.layer.Layer;
17import org.openstreetmap.josm.gui.layer.OsmDataLayer;
18import org.openstreetmap.josm.gui.util.GuiHelper;
19import org.openstreetmap.josm.tools.ImageProvider;
20import org.openstreetmap.josm.tools.Shortcut;
21
22public class MergeSelectionAction extends AbstractMergeAction {
23    public MergeSelectionAction() {
24        super(tr("Merge selection"), "dialogs/mergedown", tr("Merge the currently selected objects into another layer"),
25            Shortcut.registerShortcut("system:mergeselection", tr("Edit: {0}", tr("Merge selection")),
26            KeyEvent.VK_M, Shortcut.CTRL_SHIFT),
27            true /* register */
28        );
29        putValue("help", ht("/Action/MergeSelection"));
30    }
31
32    public void mergeSelected(DataSet source) {
33        List<Layer> targetLayers = LayerListDialog.getInstance().getModel().getPossibleMergeTargets(getEditLayer());
34        if (targetLayers.isEmpty()) {
35            warnNoTargetLayersForSourceLayer(getEditLayer());
36            return;
37        }
38        Layer targetLayer = askTargetLayer(targetLayers);
39        if (targetLayer == null)
40            return;
41        if (getEditLayer().isUploadDiscouraged() && targetLayer instanceof OsmDataLayer && !((OsmDataLayer)targetLayer).isUploadDiscouraged() 
42                && getEditLayer().data.getSelected().size() > 1) {
43            if (warnMergingUploadDiscouragedObjects(targetLayer)) {
44                return;
45            }
46        }
47        MergeSourceBuildingVisitor builder = new MergeSourceBuildingVisitor(getEditLayer().data);
48        ((OsmDataLayer)targetLayer).mergeFrom(builder.build());
49    }
50
51    public void actionPerformed(ActionEvent e) {
52        if (getEditLayer() == null || getEditLayer().data.getSelected().isEmpty())
53            return;
54        mergeSelected(getEditLayer().data);
55    }
56
57    @Override
58    protected void updateEnabledState() {
59        if (getCurrentDataSet() == null) {
60            setEnabled(false);
61        } else {
62            updateEnabledState(getCurrentDataSet().getSelected());
63        }
64    }
65
66    @Override
67    protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
68        setEnabled(selection != null && !selection.isEmpty());
69    }
70   
71    /**
72     * returns true if the user wants to cancel, false if they want to continue
73     */
74    public static final boolean warnMergingUploadDiscouragedObjects(Layer targetLayer) {
75        return GuiHelper.warnUser(tr("Merging too many objects with different upload policies"),
76                "<html>" +
77                tr("You are about to merge more than 1 object between layers ''{0}'' and ''{1}''.<br /><br />"+
78                        "<b>This is not the recommended way of merging such data</b>.<br />"+
79                        "You should instead check and merge each object, <b>one by one</b>.<br /><br />"+
80                        "Are you sure you want to continue?", getEditLayer().getName(), targetLayer.getName(), targetLayer.getName())+
81                "</html>",
82                ImageProvider.get("dialogs", "mergedown"), tr("Ignore this hint and merge anyway"));
83    }
84}
Note: See TracBrowser for help on using the repository browser.