Ticket #4401: upload.diff

src/org/openstreetmap/josm/gui/io/UploadPrimitivesTask.java

@@ -234 +234 @@
                         writer = new OsmServerWriter();
                     }
                     writer.uploadOsm(strategy, toUpload.getPrimitives(), changeset, getProgressMonitor().createSubTaskMonitor(1, false));
-                    processedPrimitives.addAll(writer.getProcessedPrimitives());
 
                     // if we get here we've successfully uploaded the data. Exit the loop.
                     //
@@ -242 +241 @@
                 } catch(OsmTransferCancelledException e) {
                     e.printStackTrace();
                     uploadCancelled = true;
-                    return;
+                    break uploadloop;
                 } catch(OsmApiPrimitiveGoneException e) {
                     // try to recover from  410 Gone
                     //
@@ -272 +271 @@
                         break uploadloop;
                     }
                 } finally {
+                    if (writer != null) {
+                        processedPrimitives.addAll(writer.getProcessedPrimitives());
+                    }
                     synchronized(this) {
                         writer = null;
                     }
@@ -285 +287 @@
         } catch (Exception e) {
             if (uploadCancelled) {
                 System.out.println(tr("Ignoring caught exception because upload is canceled. Exception is: {0}", e.toString()));
-                return;
+            } else {
+                lastException = e;
             }
-            lastException = e;
         }
-        if (uploadCancelled) return;
+        if (uploadCancelled && processedPrimitives.isEmpty()) return;
         cleanupAfterUpload();
     }
 

src/org/openstreetmap/josm/io/DiffResultProcessor.java

@@ -125 +125 @@
                 if (!p.isDeleted()) {
                     p.setOsmId(entry.new_id, entry.new_version);
                     p.setVisible(true);
+                } else {
+                    p.setVisible(false);
                 }
                 if (cs != null && !cs.isNew()) {
                     p.setChangesetId(cs.getId());

src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -888 +888 @@
         boolean changed = false;
         while (it.hasNext()) {
             OsmPrimitive primitive = it.next();
-            if (primitive.isDeleted()) {
+            if (primitive.isDeleted() && !primitive.isVisible()) {
                 selectedPrimitives.remove(primitive);
                 allPrimitives.remove(primitive);
                 primitive.setDataset(null);